Correct include dir for libslang #5539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expipiplus1
force-pushed
the
push-ymkrkzlpqwzx
branch
3 times, most recently
from
fa03b14 to
4d67630
Compare
|
Can you provide more context on why this PR is needed? |
|
ah sure, that was in the commit message but didn't make it into the PR desc: This stops adding the repo root to the include path for anything linking Somebody already hit this in fact: #5481 (comment) |
|
(ci failure is simple, I can get to that and it reflects something wrong in our build system not falcor's usage of it) |
This stops adding the repo root to the include path for anything linking with slang. This enabled a bunch of convenient includes, but might lead to confusing behavior for anyone including slang. Not to mention differences including it from an install vs source.
expipiplus1
force-pushed
the
push-ymkrkzlpqwzx
branch
from
4d67630 to
08c0018
Compare
csyonghe
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically a breaking change, but anyone using the old behaviour ought to change includes from
<include/slang.h>to just<slang.h>